Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped graylog version #324

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Bumped graylog version #324

merged 5 commits into from
Sep 11, 2024

Conversation

keyvaann
Copy link
Collaborator

Fixes the dependency error during installation

Copy link

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question.

@@ -59,7 +60,7 @@ jobs:
INSTALL_K3S_VERSION: ${{ matrix.K3S_VERSION }}
K3S_KUBECONFIG_MODE: "644"
run: |
/usr/local/bin/k3s-uninstall.sh
/usr/local/bin/k3s-uninstall.sh || true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not cause troubles when K3S is not installed for some reason? Why did you remove this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't removed, it's added

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh perfect then!

Copy link

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann
Copy link
Collaborator Author

Wow finally! The check passes!

@keyvaann keyvaann merged commit ccc0782 into dev Sep 11, 2024
3 checks passed
@keyvaann keyvaann deleted the bump-graylog branch September 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants