Skip to content

Commit

Permalink
[cc-schema-registry-proxy] Use ingressClassName instead of annotation
Browse files Browse the repository at this point in the history
  • Loading branch information
keyvaann committed Sep 24, 2024
1 parent db6fd14 commit 8b187c6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/cc-schema-registry-proxy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: "1.0"
description: A Helm chart for Confluent Cloud schema registry proxy. This proxy service is used when RADAR-base platform is used with Confluent Cloud based schema registry. It forwards requests to schema registry with an additonal basic authentication header with Confluent Cloud schema registry credentials. This service will be enabled if `cc.enabled = true`.
name: cc-schema-registry-proxy
version: 0.3.0
version: 0.3.1
type: application
home: "https://radar-base.org"
icon: "http://radar-base.org/wp-content/uploads/2022/09/Logo_RADAR-Base-RGB.png"
Expand Down
5 changes: 3 additions & 2 deletions charts/cc-schema-registry-proxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# cc-schema-registry-proxy
[![Artifact HUB](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/cc-schema-registry-proxy)](https://artifacthub.io/packages/helm/radar-base/cc-schema-registry-proxy)

![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0](https://img.shields.io/badge/AppVersion-1.0-informational?style=flat-square)
![Version: 0.3.1](https://img.shields.io/badge/Version-0.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0](https://img.shields.io/badge/AppVersion-1.0-informational?style=flat-square)

A Helm chart for Confluent Cloud schema registry proxy. This proxy service is used when RADAR-base platform is used with Confluent Cloud based schema registry. It forwards requests to schema registry with an additonal basic authentication header with Confluent Cloud schema registry credentials. This service will be enabled if `cc.enabled = true`.

Expand Down Expand Up @@ -38,7 +38,8 @@ A Helm chart for Confluent Cloud schema registry proxy. This proxy service is us
| ingress.enabled | bool | `true` | Enable ingress controller resource |
| ingress.annotations | object | check values.yaml | Annotations that define default ingress class, certificate issuer |
| ingress.path | string | `"/schema/?(.*)"` | Path within the url structure |
| ingress.pathType | string | `"ImplementationSpecific"` | |
| ingress.pathType | string | `"ImplementationSpecific"` | Ingress Path type |
| ingress.ingressClassName | string | `"nginx"` | IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+) |
| ingress.hosts | list | `["localhost"]` | Hosts to accept requests from |
| ingress.tls.secretName | string | `"radar-base-tls"` | TLS Secret Name |
| cc.schemaRegistryApiKey | string | `"srApiKey"` | Confluent cloud schema registry API key |
Expand Down
2 changes: 2 additions & 0 deletions charts/cc-schema-registry-proxy/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ metadata:
nginx.ingress.kubernetes.io/upstream-vhost: {{ $externalName }}
{{- end }}
spec:
ingressClassName: {{ .Values.ingress.ingressClassName | quote }}
{{- if and .Values.ingress.tls (not .Values.disable_tls) }}
tls:
- hosts:
Expand Down Expand Up @@ -56,3 +57,4 @@ spec:
{{- end }}
{{- end }}
{{- end }}

4 changes: 3 additions & 1 deletion charts/cc-schema-registry-proxy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ ingress:
# -- Annotations that define default ingress class, certificate issuer
# @default -- check values.yaml
annotations:
kubernetes.io/ingress.class: nginx
cert-manager.io/cluster-issuer: letsencrypt-prod
ingress.kubernetes.io/preserve-host: "false"
nginx.ingress.kubernetes.io/rewrite-target: /$1
nginx.ingress.kubernetes.io/backend-protocol: https
# -- Path within the url structure
path: "/schema/?(.*)"
# -- Ingress Path type
pathType: ImplementationSpecific
# -- IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+)
ingressClassName: nginx
# -- Hosts to accept requests from
hosts:
- localhost
Expand Down

0 comments on commit 8b187c6

Please sign in to comment.