Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-manager 1.14.5 #123

Merged
merged 1 commit into from
Apr 30, 2024
Merged

cert-manager 1.14.5 #123

merged 1 commit into from
Apr 30, 2024

Conversation

Bdegraaf1234
Copy link
Member

Description of the change

Update the cert-manager chart to appversion 1.14.5

Benefits

More up to date helmchart, fix at least one CVE

Possible drawbacks

Applicable issues

NA

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 self-assigned this Apr 30, 2024
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be enough, we actually need to fetch and mirror the latest changes from the upstream cert-manager helm chart. The command should look something like this https://github.com/RADAR-base/radar-helm-charts/pull/65/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R14

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to test it and see if it actually works

@Bdegraaf1234 Bdegraaf1234 merged commit 88b5683 into main Apr 30, 2024
1 check passed
@Bdegraaf1234 Bdegraaf1234 deleted the cert-manager-1.14.5 branch May 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants