Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management-portal] Support setting AAL2 and identityserver login url #215

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[management-portal] Support setting AAL2 and identityserver login url #215

merged 1 commit into from
Jul 11, 2024

Conversation

Bdegraaf1234
Copy link
Member

Description of the change

Add support for the configuration of AAL2 and the identityserver login url to managementportal.

Benefits

we can set these values

Possible drawbacks

The development of MP is currently very active, and these variables may change relatively soon

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 self-assigned this Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@Bdegraaf1234 Bdegraaf1234 force-pushed the update-managementportal branch 2 times, most recently from 1426a4b to ac068be Compare July 5, 2024 14:52
@Bdegraaf1234
Copy link
Member Author

@keyvaann ready for review/to merge

keyvaann
keyvaann approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit a3f35cb into main Jul 11, 2024
5 checks passed
@keyvaann keyvaann deleted the update-managementportal branch July 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees

@Bdegraaf1234 Bdegraaf1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bdegraaf1234 @keyvaann