[management-portal] Impl. default values for Ory URLs #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/managementportal-ory-url-defaults
branch
from
84a6f2f
to
54d9f8c
Compare
pvannierop
force-pushed
the
feature/managementportal-ory-url-defaults
branch
from
54d9f8c
to
9744f7a
Compare
|
LGTM, thanks! |
There was a problem hiding this comment.
Might be nice to lhave @keyvaann verify but this all LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
URLs for kratos had to be set in production.yaml for Ory integration to work.
Solution
This PR will derive default values for Ory URLs. The current values can be used to override the defaults.