Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catalog-server] Fix appversion in docker image tag #235

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[catalog-server] Fix appversion in docker image tag #235

merged 1 commit into from
Jul 30, 2024

Conversation

pvannierop
Copy link
Collaborator

The appversion was not correctly passed after not defining tag in values.yaml.

@pvannierop pvannierop requested a review from keyvaann July 30, 2024 08:23
@pvannierop pvannierop self-assigned this Jul 30, 2024
keyvaann
keyvaann approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop merged commit d9aa8af into main Jul 30, 2024
5 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the bugfix/catalog-server-add-appversion branch August 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees

@pvannierop pvannierop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvannierop @keyvaann