Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push endpoint ingress #238

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix push endpoint ingress #238

merged 1 commit into from
Jul 31, 2024

Conversation

keyvaann
Copy link
Collaborator

Trying to fix the following warning:

W0731 15:18:47.853758  395615 warnings.go:70] path /push-endpoint/?(.*) cannot be used with pathType Prefix

@keyvaann keyvaann requested a review from pvannierop July 31, 2024 15:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

pvannierop
pvannierop approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit 5a9ef30 into main Jul 31, 2024
5 checks passed
@keyvaann keyvaann deleted the fix-push-endpoint-ingress branch July 31, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvannierop pvannierop pvannierop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyvaann @pvannierop