Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade appversions of various services #248

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

pvannierop
Copy link
Collaborator

see title

@pvannierop pvannierop self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 23, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Did not see an update since a long time because it was listed in .helmdocsignore. I presume because of the need to manually format the extraEnv[0].name and extraEnv[0].value table entries.
I updated the DOCS gotmpl to conform to the original docs as stated by Joris (overwritten in a recent docs update) and I removed the entry from .helmdocsignore.
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop merged commit 47349b4 into main Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants