[radar-self-enrolment-ui] fix radar SEP ui chart

[yatharthranjan]

Description of the change

Fixes a minor issue with the radar self-enrolment UI chart that prevents it from deploying.

Benefits

Possible drawbacks

Applicable issues

Error: release kratos-selfservice-ui-node failed, and has been uninstalled due to atomic being set: failed pre-install: unable to build kubernetes object for deleting hook radar-self-enrolment-ui/templates/secret.yaml: unable to decode "": json: cannot unmarshal number into Go struct field ObjectMeta.metadata.annotations of type string

Additional information

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

[mpgxvii]

Thanks for this. I was also running into an issue with the healthcheck:

radar-helm-charts/external/radar-self-enrolment-ui/templates/deployment.yaml

Lines 88 to 94 in 0a431b9

	livenessProbe:
	httpGet:
	path: {{ .Values.basePath }}/health/alive
	port: http
	readinessProbe:
	httpGet:
	path: {{ .Values.basePath }}/health/ready

I've added it temporarily to the image but the endpoint is /api/health/alive. Or should we just remove temporarily?

[yatharthranjan]

Ok, thanks; please make an update here, in that case, to add ../api/... Yes, it is okay to remove it temporarily for testing purposes our production.yaml using

| deployment.customLivenessProbe | object | `{}` | Configure a custom livenessProbe. This overwrites the default object |
| deployment.customReadinessProbe | object | `{}` | Configure a custom readinessProbe. This overwrites the default object |

But please issue a fix here for the correct URL.

[keyvaann]

At the moment charts in the external directory is considered to be the mirror of the upstream chart and during updates they'll be removed and redownloaded from the source. If you want to make changes to it, I suggest either moving it to the charts directory or applying the changes in RADAR-Kubernetes repo.

[yatharthranjan]

Yes good point, @mpgxvii i think we can move this to the charts directory as it is maintained by RADAR-base and not externally.

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

• Is the PR adding a new container? Please reviewer, add it to the models (internal process)
• Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

[mpgxvii]

@keyvaann @yatharthranjan I've made the changes, but I'm not sure why the helm-docs lint check is failing. Is it because I moved it to a new directory?

[keyvaann]

@mpgxvii did you run make gen command?

[mpgxvii]

@mpgxvii did you run make gen command?

@keyvaann Yeah but it wasn't changing anything. Apparently it was my helm-docs version. Updated this now.

[keyvaann]

LGTM