Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radar-gateway] Update configmap variables #270

Merged
merged 3 commits into from
Oct 18, 2024
Merged

[radar-gateway] Update configmap variables #270

merged 3 commits into from
Oct 18, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Oct 15, 2024

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

Copy link

github-actions bot commented Oct 15, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@@ -228,3 +228,7 @@ cc:
schemaRegistryApiKey: srApiKey
# -- Confluent Cloud schema registry API secret
schemaRegistryApiSecret: srApiSecret

public_key_endpoints:
# List of public key endpoints for token verification
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation should be above the item

Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the doc and default. LGTM

@keyvaann
Copy link
Collaborator

Thanks!

@keyvaann keyvaann merged commit 706440e into main Oct 18, 2024
5 checks passed
@keyvaann keyvaann deleted the update-gateway branch October 18, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants