Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp improvements #43

Open
NoahAndrews opened this issue Nov 11, 2024 · 0 comments
Open

Timestamp improvements #43

NoahAndrews opened this issue Nov 11, 2024 · 0 comments

Comments

@NoahAndrews
Copy link
Member

NoahAndrews commented Nov 11, 2024 •
edited
Loading

  1. All returned timestamps should be defined in the same unit and reference frame as WPILib's CAN timestamps
    1. WPILib doesn't do a fantastic job of being consistent and documenting how timestamps work. Improve this upstream, and make sure that the behavior is consistent between simulation and the roboRIO.
  2. All timestamp values should have a type of uint64_t
    1. WPILib HAL timestamps are typed as uint32_t, unfortunately. We'll need to use CANMessage for our internal CAN stream data representation, rather than the WPILib version like we do now.
@NoahAndrews NoahAndrews changed the title Timstamp improvements Timestamp improvements Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoahAndrews