Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel][rsoc]tick long long unit #9496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Oct 1, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#9482

你的解决方案是什么 (what is your solution)

添加kcong将他配置为64位,默认还是32位

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@github-actions github-actions bot added the Kernel PR has src relate code label Oct 1, 2024
src/Kconfig Outdated
@@ -116,6 +116,12 @@ config RT_TICK_PER_SECOND
help
System's tick frequency, Hz.

config RT_USING_TICK_LL_UNIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config RT_USING_TICK_LL_UNIT
config RT_TICK_USING_64BIT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

src/Kconfig Outdated
@@ -116,6 +116,12 @@ config RT_TICK_PER_SECOND
help
System's tick frequency, Hz.

config RT_USING_TICK_LL_UNIT
bool "Using long long as tick unit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool "Using long long as tick unit"
bool "Using 64-bit systick"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@CYFS3 CYFS3 requested a review from Rbb666 as a code owner October 1, 2024 03:06
@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Oct 1, 2024
@BernardXiong
Copy link
Member

BernardXiong commented Oct 1, 2024

tick更改成64bit的,需要对TICK_MAX/2做完整性分析

建议:
对tick进行更改时,对32位tick下的超时机制/tick最大时长/tick回绕进行完整分析,并对相关场合代码在64位tick下的影响都完整检查过。

@BernardXiong BernardXiong added the discussion This PR/issue needs to be discussed later label Oct 1, 2024
@CYFS3 CYFS3 marked this pull request as draft October 2, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 BSP discussion This PR/issue needs to be discussed later Kernel PR has src relate code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants