Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dev dependency #10032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Dec 2, 2024

Summary

I noticed that discord.py doesn't have a optional list of dependencies needed to develop the library. So here it is.

Black and Pyright versions are straight from the lint workflow.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Soheab Soheab changed the title Add optional dev dependencies Add optional dev dependency Dec 2, 2024
dev = [
"black==22.6",
"typing_extensions>=4.3,<5",
"pyright==1.1.351",
Copy link
Contributor

@AbstractUmbra AbstractUmbra Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a questionable addition since pyright itself is actually an npm package. The python module uses nodeenv which by the authors own admission is less stable than using pyright[nodejs] which uses nodejs-wheel in its stead.

My suggestion would be omitting this entirely and letting the users use Pylance or their own installation of pyright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants