Improves error messages for ClassLists #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhroom
requested changes
Oct 1, 2024
There was a problem hiding this comment.
looks good (as good as the Pydantic errors) but i think we could maybe push them to be better than the Pydantic errors, to make users' lives a lot simpler if they've got large lists. I also think that _validate_name_field could be updated to have a better error that e.g. says what indices the name is already defined at
alexhroom
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ClassList._check_classesandClassList._check_unique_name_fieldsroutines to provide better error messages, specifically including the indices of the bad input in the input lists. This may help with mitigating the coercion issue identified in #79 alongside giving better information for bad input to routines that mutate ClassLists.I'm open to input about the format of the error messages.