Add ansible, rhel, and openshift link selectors to services dropdown #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crc
ryelo
requested changes
Jul 24, 2024
data/crc.yml
Outdated
Comment on lines
37
to
45
| "Apps & Services Dropdown - Ansible": | ||
| selectors: | ||
| - '{} [data-ouia-component-id="AllServices-Dropdown-Ansible"]' | ||
| "Apps & Services Dropdown - RHEL": | ||
| selectors: | ||
| - '{} [data-ouia-component-id="AllServices-Dropdown-RHEL"]' | ||
| "Apps & Services Dropdown - Openshift": | ||
| selectors: | ||
| - '{} [data-ouia-component-id="AllServices-Dropdown-Openshift"]' |
There was a problem hiding this comment.
Suggested change
| "Apps & Services Dropdown - Ansible": | |
| selectors: | |
| - '{} [data-ouia-component-id="AllServices-Dropdown-Ansible"]' | |
| "Apps & Services Dropdown - RHEL": | |
| selectors: | |
| - '{} [data-ouia-component-id="AllServices-Dropdown-RHEL"]' | |
| "Apps & Services Dropdown - Openshift": | |
| selectors: | |
| - '{} [data-ouia-component-id="AllServices-Dropdown-Openshift"]' | |
| "Apps & Services Dropdown - Ansible": | |
| selectors: | |
| - '[data-ouia-component-id="AllServices-Dropdown-Ansible"]' | |
| "Apps & Services Dropdown - RHEL": | |
| selectors: | |
| - '[data-ouia-component-id="AllServices-Dropdown-RHEL"]' | |
| "Apps & Services Dropdown - Openshift": | |
| selectors: | |
| - '[data-ouia-component-id="AllServices-Dropdown-Openshift"]' |
You can remove the scope for these since they're going to be present on every page. You should be able to delete your changes further down since this will capture all the clicks sitewide
|
Also, whenever this is updated it can be merged. There's nothing that will break if we merge it early but it'll start capturing data as soon as chrome is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RHCLOUD-33602, currently waiting for a new frontend release with these ouia selectors added