Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removes provider from init and moves CI templates #344

Merged
merged 9 commits into from
Sep 16, 2024
Merged

feat: removes provider from init and moves CI templates #344

merged 9 commits into from
Sep 16, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Sep 12, 2024 •
edited
Loading

Description

This moves the CI templates out from the trestle-bot packages and allows users to copy them from TEMPLATES
Fixes #343

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
fix(init): updates mismatches between init and the initial workflow f…
67f6283 
…iles

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: removes provider from init entrypoint
b52fdb5 
To simplfy this feature, the provider workflows
will be available in the repo under TEMPLATES to copy
manually.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
docs: updates tutorial and corrects workflows
23db548 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
test: adds back unit tests for directory validation
3ff376e 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
test: adds back tests for trestlebot keep file
b6b251d 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
gvauter
gvauter approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

huiwangredhat
huiwangredhat reviewed Sep 13, 2024
View reviewed changes
docs/tutorials/github.md

**For example Component Definition authoring in GitHub Actions**
```
cp TEMPLATES/github/trestlebot-create-component-definition.yml .github/workflows
Copy link

@huiwangredhat huiwangredhat Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .github dir won't be generated after the trestlebot init and has been removed on line 53. So .github needs to be created manually. Is that the expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The .github/workflows directory would need to be created. Thanks for pointing that out. I could include a mkdir line.

@huiwangredhat
Copy link

huiwangredhat commented Sep 13, 2024 •
edited
Loading

The job failed after copying the workflow .github/workflows/trestlebot-rules-transform.yml. More details: https://github.com/huiwangredhat/trestlebot-demo3/actions/runs/10842292114(I guess it should be contents: write). The workflow files are allowed to be updated by the end users according to the requirements, am I right?

@jpower432
Copy link
Member Author

The job failed after copying the workflow .github/workflows/trestlebot-rules-transform.yml. More details: https://github.com/huiwangredhat/trestlebot-demo3/actions/runs/10842292114(I guess it should be contents: write). The workflow files are allowed to be updated by the end users according to the requirements, am I right?

You are right! Thank you finding this issue.

@jpower432
fix: addresses PR feedback
3c3b17f 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore(deps): removes extra dependency for importlib
477e204 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
docs: fixes GitHub tutorial steps
c7b3693 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
fix: updates unit tests for trestle API breaking change
492949b 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
huiwangredhat
huiwangredhat approved these changes Sep 14, 2024
View reviewed changes
Copy link

@huiwangredhat huiwangredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply. LGTM.

@jpower432 jpower432 merged commit 21b4043 into main Sep 16, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
This was referenced Sep 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huiwangredhat huiwangredhat huiwangredhat approved these changes

@gvauter gvauter gvauter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move workflow templates out of trestlebot package
3 participants
@jpower432 @huiwangredhat @gvauter