Fix links #99
Merged
Fix links #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShimShtein The tests are still failing and I'm not sure what is wrong nor if my fix is correct. Please, help? |
ShimShtein
force-pushed
the
fix-links
branch
2 times, most recently
from
dca59d7
to
0821b7f
Compare
ShimShtein
reviewed
Nov 11, 2024
| @@ -78,7 +78,7 @@ module Documentation | |||
| 'Products_and_Repositories_content-management' => "#{ForemanThemeSatellite.documentation_root}/managing_content/importing_content_content-management#Products_and_Repositories_content-management", | |||
| }, | |||
| 'Managing_Hosts' => { | |||
| 'registering-a-host_managing-hosts' => "#{ForemanThemeSatellite.documentation_root}/managing_hosts/registering_hosts_to_server_managing-hosts#Registering_Hosts_by_Using_Global_Registration_managing-hosts", | |||
| 'registering-a-host_managing-hosts' => "#{ForemanThemeSatellite.documentation_root}/managing_hosts/registering-hosts-and-setting-up-host-integration_managing-hosts#Registering_Hosts_by_Using_Global_Registration_managing-hosts", | |||
There was a problem hiding this comment.
@Lennonka I have rolled back the change to the key (registering-a-host_managing-hosts). This key is used in the upstream foreman. We want to make sure that when the code calls for the upstream value like here:
https://github.com/theforeman/foreman/blob/9d0f388296a845ebcba944e9fc04570a42f5ceea/webpack/assets/javascripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/index.js#L203
the theme will serve the downstream link.
ShimShtein
approved these changes
Nov 11, 2024
|
Squashed y'alls commits to make them pretty ✨ and going to merge this. Thank you two! |
evgeni
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing links based on #91.