Refactor redisgraph.js to Typescript

[DenisCarriere]

Refactor redisgraph.js to Typescript

Issue Ref: #5

I was very surprised to see Redis wasn't using Typescript, it's rare to see new libraries built using CommonJS syntax.

[davidLeonardi]

👏 👏 👏 👏

[DenisCarriere]

I'll be sending more PR's once this is merged

[DenisCarriere]

@gkorland would you prefer just adding the Typescript types instead of the entire code being refactored?

[gkorland]

@DenisCarriere I would prefer not to switch to TypeScript, if we need any special things that will help you TypeScript consume the client please feel free to send another PR

[renewooller]

looks like another one for definitely typed. It's a shame cause I can see they're already getting type errors that you've probably fixed in your refactoring eg #19

[DvirDukhan]

Thanks, @DenisCarriere.
We decided not to refactor our current JS client to TypeScript.
If you like, you can fork and modify it to a TypeScript client. When your work is done, we will be happy to add the reference to your repo.

[jonaskello]

Just found redisgraph and this lib and was excited to start using it. Well, fired it up and went yarn add --dev @types/redisgraph.js and to my suprise there were no types there. I would tend to agree with the above, this is a fairly new project so I just expected it to be compatible with modern mainstream technologies. To be honest I'm a bit disappointed, now instead of being able to code away on a cool redisgraph project, I'm stuck to solve the typing problem myself which will seriously slow me down :-/.

For reference this was written 2016 and today I guess most people just expect any serious library to just work for typescript: https://staltz.com/all-js-libraries-should-be-authored-in-typescript.html

[jonaskello]

Btw, forking a separate typescript client is probably not a good idea. There are no specific typescript libraries, there are only javascript libraries which provides typescript annotations. If this project does not want to use typescript annotations internally, then it should provide them externally on definetely typed which will then end up published as @types/redisgraph.js.

[jdgamble555]

Anything on approving this?

[gkorland]

@jdgamble555 RedisGraph support was moved to node-redis see: https://github.com/redis/node-redis