Add some code tweaks

RedisInsight · Oct 5, 2022 · 3147597 · 3147597
1 parent adf48e1
commit 3147597
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/app/models/key-models/bfkey.cpp b/src/app/models/key-models/bfkey.cpp
@@ -44,14 +44,13 @@ void BloomFilterKeyModel::loadRows(QVariant, unsigned long,
     return callback(err, 0);
   };
 
-  auto responseHandler = [this, callback](RedisClient::Response r, Callback) {
+  auto responseHandler = [this, callback](const RedisClient::Response& r, Callback) {
     m_rowsCache.clear();
     auto value = r.value().toList();
 
     QVariantMap row;
 
-    for (QVariantList::const_iterator item = value.cbegin(); item != value.cend();
-         ++item) {
+    for (auto item = value.cbegin(); item != value.cend(); ++item) {
       auto key = item->toByteArray();
       ++item;
 

diff --git a/src/app/models/key-models/bfkey.h b/src/app/models/key-models/bfkey.h
@@ -12,10 +12,16 @@ class BloomFilterKeyModel : public KeyModel<QVariant> {
   QVariant getData(int rowIndex, int dataRole) override;
 
   void addRow(const QVariantMap&, Callback c) override;
+
   virtual void updateRow(int, const QVariantMap&,
-                         Callback) override {}
+                         Callback) override {
+      // NOTE(u_glide): BF/CF is read-only
+  }
   void loadRows(QVariant, unsigned long, LoadRowsCallback callback) override;
-  void removeRow(int, Callback) override {}
+
+  void removeRow(int, Callback) override {
+      // NOTE(u_glide): BF/CF is read-only
+  }
 
   virtual unsigned long rowsCount() override { return m_rowCount; }