-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncated QR with Pivoting #891
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
=========================================
Coverage 0.00% 0.00%
=========================================
Files 1918 1930 +12
Lines 188614 190055 +1441
=========================================
- Misses 188614 190055 +1441 ☔ View full report in Codecov by Sentry. |
may I suggest using a more specific PR title (and perhaps branch name as well) in the future, unless you really want the enhancement to be a pleasant surprise ? |
+1 on @martin-frbg's comment |
I haven't had time to fully review the code itself, but I want to note that multiple colleagues of mine have asked for this feature. I can certainly approve the addition of truncated QR to LAPACK. @scr2016 please don't get discouraged if it takes a long time for this to be merged. Features like this can take a long time. |
…ents in dlaqp3rk.f
… comments at the end of dlaqp2rk.f about setting MAXC2NRMK, RELMAXC2NRMK and TAU
…BSTOL and RELTOL criteria satisfaction for the whole original matrix A
…turn from the loop instead of exiting the loop when ABSTOL or RELTOL criterion is satisfied
…riginal matrix when MAXC2NRM<= ABSTOL and ONE <=RELTOL
….QE.1 ) THEN and F( MAXC2NRMK.EQ.ZERO ) THEN into IF( I.NE.1 .AND. MAXC2NRMK.EQ.ZERO ) THEN
…NE parameter in the calling sequence
…be ... and for complex case added a factor of 10 as min( 10*max(M,N)*EPS, sqrt(EPS) ) <= RELTOL
…p3rk.f schkqp3rk.f
Update of the documentation to the pull request "Truncated QR with Pivoting #891"
Description
This is a pull request for a truncated QR with column pivoting {S,D,C,Z} (*GEQP3RK, *LAQP2RK, *LAQP3RK) with 3 truncation (stopping) criteria plus one implicit:
It has NaN and Inf reporting (see the description of the routines) which relies on the "correct" NaN and Inf reporting of IDAMAX/ISAMAX (I.e. the index of the first NaN occurrence is returned, else the index of the first +/-Inf occurrence is returned, else the index if the first MAX element by absolute value is returned ).
Checklist