Simplify API #24
Merged
Simplify API #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronErhardt
approved these changes
Oct 27, 2024
build_icons/src/lib.rs
Outdated
| @@ -48,11 +51,12 @@ pub fn bundle_icons<P, I, S>( | |||
| S: Into<Cow<'static, str>> + Display + Clone, | |||
There was a problem hiding this comment.
I didn't notice in the other PR, but P: AsRef<Path> + Display doesn't make sense. You could write &str and it would be effectively the same.
There was a problem hiding this comment.
Does it look better now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #19, which while works, has slightly annoying API, which could be improved.
I also improved formatting and docs in generated file and resolved potential conflict with multiple
resources.gresourcefiles.