Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate(pt/developer-docs/real-examples) #153

Merged

Conversation

G3mha
Copy link
Contributor

@G3mha G3mha commented Nov 25, 2024

Finish translating the file docs/pt/developer-docs/real-examples.md to pt-BR.

Translates the files docs/pt/developer-docs/real-examples/* to pt-BR

…mvent-the-problem-of-a-counter-incrementing-twice-in-the-same-frame.md` to pt-BR
…tting on `circumvent-the-problem-of-a-counter-incrementing-twice-in-the-same-frame.md` in EN and ES
…ing-a-timer-with-reset-if-hits-based-on-the-speed-of-the-game.md` to pt-BR
…tting on `creating-a-timer-with-reset-if-hits-based-on-the-speed-of-the-game.md` in EN and ES
…-add-source-and-deltas-for-collectibles-and-similar-achievements.md` to pt-BR
…tting on `using-add-source-and-deltas-for-collectibles-and-similar-achievements.md` in EN
@wescopeland
Copy link
Member

There's a similar image issue in these files as was discovered in #152.

Definitely not your doing - it's from our ancient legacy docs. But while we're touching these files, it'd be very beneficial if we could move any external images into the repo itself.

Copy link
Contributor Author

@G3mha G3mha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned into issues!

@G3mha
Copy link
Contributor Author

G3mha commented Nov 27, 2024

@wescopeland Ready for re-review. Turned the image link into a local image file.

@G3mha
Copy link
Contributor Author

G3mha commented Nov 27, 2024

@gboquizosanchez I've updated several achievement editor images and their descriptions to follow the repo's best practices now, as instructed by @wescopeland. Since some of these pages have Spanish translations, would you mind reviewing the Spanish alt text changes to ensure they follow the translation standards for ES? Thanks!

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gboquizosanchez I will hold off on merging for 48 hours.

@wescopeland wescopeland merged commit 8e9dcea into RetroAchievements:main Dec 2, 2024
1 check passed
@G3mha G3mha deleted the pt-developer-docs-real-examples branch December 3, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants