Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Remove pipelines inherited from upstream #168

Merged
merged 1 commit into from
Sep 12, 2023
Merged

.github: Remove pipelines inherited from upstream #168

merged 1 commit into from
Sep 12, 2023

Conversation

iluminat23
Copy link

This deprecates #163

@iluminat23 iluminat23 changed the title .github: Remove piplines inherited from upstream .github: Remove pipelines inherited from upstream Sep 11, 2023
@l1k l1k requested a review from tboehler1 September 11, 2023 13:34
@l1k
Copy link

l1k commented Sep 11, 2023

Is this the reason why #169 is failing checkpatch tests?

@tboehler1 Does this look okay to you? I'm not familiar with CI stuff.

@tboehler1
Copy link

I'm not sure what the reason the CI in that PR is failing is, but removing this would stop that from running.

@l1k
Copy link

l1k commented Sep 11, 2023

@tboehler1 I don't quite follow. I assume "would stop that from running" refers to the checkpatch test? But don't we have a checkpatch test of our own?

Again, does this look okay to you?

@iluminat23
Copy link
Author

What is failing?

Copy link

@tboehler1 tboehler1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me if you want to remove the CI from upstream.

@l1k
Copy link

l1k commented Sep 12, 2023

@iluminat23

What is failing?

The Advisory checkpatch review run.

@l1k l1k merged commit a7a577d into RevolutionPi:revpi-6.1 Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants