Unable verbose log and fix a bug in NICK command

Ria9993 · Apr 13, 2024 · c841fb6 · c841fb6
1 parent 5ff3c3a
commit c841fb6
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 16 deletions.
diff --git a/Source/Core/SharedPtr.hpp b/Source/Core/SharedPtr.hpp
@@ -289,7 +289,6 @@ class SharedPtr
 
                 if (mControlBlock->WeakRefCount == 0)
                 {
-                    CoreLog("SharedPtr Reset(): Delete ControlBlock" + std::string(typeid(T).name()));
                     delete mControlBlock;
                 }
             }

diff --git a/Source/Core/WeakPtr.hpp b/Source/Core/WeakPtr.hpp
@@ -112,7 +112,6 @@ class WeakPtr
             {
                 if (mControlBlock->StrongRefCount == 0)
                 {
-                    CoreLog("WeakPtr Reset(): Delete ControlBlock" + std::string(typeid(T).name()));
                     delete mControlBlock;
                 }
             }

diff --git a/Source/Server/ClientCommand/NICK.cpp b/Source/Server/ClientCommand/NICK.cpp
@@ -73,6 +73,10 @@ EIrcErrorCode Server::executeClientCommand_NICK(SharedPtr<ClientControlBlock> cl
                 channel->Clients.erase(client->Nickname);
                 channel->Clients.insert(std::make_pair(client->Nickname, client));
             }
+            else
+            {
+                client->Channels.erase(it);
+            }
         }
 
         // Send NICK message to all channels the client is in

diff --git a/Source/Server/Server.cpp b/Source/Server/Server.cpp
@@ -598,7 +598,6 @@ EIrcErrorCode Server::processClientMsg(SharedPtr<ClientControlBlock> client, Sha
     // ! DEBUG
     if (msgCommandToken != NULL && strcmp(msgCommandToken, "QUIT") == 0)
     {
-        destroyResources();
         return IRC_FAILED_UNREACHABLE_CODE;
     }
 

diff --git a/Source/Server/Server.hpp b/Source/Server/Server.hpp
@@ -31,19 +31,6 @@ namespace IRC
     /** @class Server
      *  @internal
      *  @note  See [ \ref irc_server_event_loop_process_flow ] before reading implementation details.
-     *  
-     *  @dot
-     *  digraph ServerClientChannel {
-     *     node [shape=record];
-     *     Server [label="Server"];
-     *     Client [label="ClientControlBlock"];
-     *     Channel [label="ChannelControlBlock"];
-     *  Server -> Client;
-     *  Server -> Channel;
-     *  Channel -> Client;
-     *  Client -> Channel [label="WeakPtr"];
-     *  }
-     *  @enddot
      * 
      * 
      *  @page irc_server_event_loop_process_flow    Server Event Loop Process Flow