feat(engine): json protocol #1035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ProgramRipper
commented
Sep 29, 2024
| # FieldNotFoundError, | ||
| # match=r'Field \'foo_field\' not found in enclosing type \'Post\'', | ||
| # ): | ||
| # await CustomPost.prisma().find_first() |
There was a problem hiding this comment.
Caution
test_field_not_found_error_selection skipped
JSON protocol does not explicitly select all fields, so it won't raise a FieldNotFoundError here.
However we could:
- explicitly select all fields (cons: this could be hard to impl and bring overhead to serializer, prisma-engine and maybe even db); or...
- leave it to pydantic as it will raise validation errors if data doesn't match the model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #707, #748
Change Summary
A naive implementation of JSON protocol based on #748.
Checklist
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.