Robot distance #14
Merged
Robot distance #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supertom01
requested changes
Mar 18, 2024
| /** | ||
| * Maximum radius of the robot in meters | ||
| */ | ||
| private final double radius = 0.09; |
There was a problem hiding this comment.
Is there are reason that this variable is hard-coded? Some robots are wider than others (this information should be known by SSL-vision).
In the case that you're okay with the error I recommend making it a proper constant:
Suggested change
| private final double radius = 0.09; | |
| public static final double radius = 0.09; |
This makes sure that you do not have to pass each robot object to all of the funtions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the distance from the robot to another points needs to be measured it should be from the edge of the robot and not the center. Fixed this in this pull request