Not Splines #28
Open
Not Splines #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the hatch given a distance and angle – will need another angle though, or absolute robot position.
…n move the specified distance.
…d (still need to do interestingauton).
…nikhil said it was unneeded.
NikhilSuresh24
requested changes
Feb 19, 2019
| @@ -14,6 +14,8 @@ | |||
| import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; | |||
There was a problem hiding this comment.
you don't need to change robot.java in this PR
There was a problem hiding this comment.
checkout master's version of Robot.java
|
|
||
| import org.usfirst.frc4904.standard.custom.sensors.PDP; | ||
| import org.usfirst.frc4904.standard.custom.PCMPort; | ||
| //import org.usfirst.frc4904.standard.custom.sensors.CANEncoder; |
There was a problem hiding this comment.
Don't have commented out code in a PR
| } | ||
| public static class PID { | ||
| public static class Drive { | ||
| public static final double P = 0.04; //Tune PID |
| import org.usfirst.frc4904.standard.commands.RunIf; | ||
| import org.usfirst.frc4904.standard.commands.RunIfElse; | ||
|
|
||
| public class BoringAuton extends CommandGroup { |
There was a problem hiding this comment.
RENAME THIS COMMAND POR FAVOR
src/main/java/org/usfirst/frc4904/sovereignty/AligningSystem.java
Outdated
Show resolved
Hide resolved
|
Can you remove sovereignty from this branch and make a new branch off this branch with sovereignty @Krakavius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with the same goal in mind as splines, but isn't splines. Sovereignty stuff is for PID (osher requested, nowhere close to done with it).