Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #73: Markdown render while listing all issues of repository #86

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

kanishbodhwani
Copy link
Contributor

Issue(s) #73

Proposed changes (including videos or screenshots)

  • Markdown is fixed with all possible issues that can occur due to URL. Eg - Removed Square brackets , backticks and quotes.

ss

Further comments

  • Removing all the occurrences of NOT-VALID URL characters.

@kanishbodhwani
Copy link
Contributor Author

Backticks breaking

Screenshot 2023-03-31 at 12 31 13 AM

@@ -56,6 +56,7 @@ export async function issueListMessage({
await modify.getCreator().finish(textSender);
resData.forEach(async (issue) => {
if (typeof issue.pull_request === "undefined" && ind < 10) {
issue.title = issue.title.replace(/[\[\]()`]/g, "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kanishbodhwani thanks 🚀

@samad-yar-khan samad-yar-khan merged commit 5d8f544 into RocketChat:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants