refactor(language-lsp): improve signature help trigger, basic diagnostics support #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove an unnecessary logging statement from LspLanguage to reduce noise and improve performance. - Improve the signature help trigger logic by adding support for triggering it when the selection changes and the character at the selection's left boundary matches a specific condition. - Adjust thread usage in LspEditor to ensure that the `sleep` operation is performed on a background thread using `Dispatchers.IO`. - Remove the `FIXME` comment in DefaultLanguageClient, as the support for diagnostics is now implemented. - Change the `StreamProvider` interface in CustomConnectProvider to a functional interface, simplifying its usage and improving code readability. - Add logging statement in `LspCompletionItem` for debugging purposes.
…ead.sleep` with `delay` for pausing execution during LSP connection retries. This change utilizes Kotlin coroutines for asynchronous operations and avoids blocking the thread.
This commit implements basic diagnostics support for the LSP client. - Added event listeners for content and selection changes to trigger diagnostic requests. - Implemented diagnostic request and publishing logic within the event handling mechanism. - Updated the request manager to support diagnostic requests. - Adjusted event data handling for diagnostics to improve type safety and clarity.
dingyi222666
changed the title
This change addresses a potential bug where diagnostics were being updated from a background thread, potentially leading to unexpected behavior or crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sleepoperation is performed on a background thread usingDispatchers.IO.FIXMEcomment in DefaultLanguageClient, as the support for diagnostics is now implemented.StreamProviderinterface in CustomConnectProvider to a functional interface, simplifying its usage and improving code readability.