add L_band option, fast scanning mode option, customizable min/max frequency, fix rssi.value if >127, show rssi, change app name to Frequency scanner #5
Conversation
singlag
changed the title
|
Can the RX5800 even go as low as L-band? |
|
According to the datasheet, even R1 is out of spec. |
|
In general the modules can operate down in those 'L' frequencies; just not as efficiently |
|
I connect my arduino board to hawkeye little pilot 5inch fpv monitor which is rx5808 inside, it come with 48channel preset include L-band
|
| @@ -35,10 +35,10 @@ | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| public class MainActivity extends AppCompatActivity { | |||
| private static final int MIN_FREQ = 5645; | |||
| private static final int MAX_FREQ = 5945; | |||
| private static int MIN_FREQ = 5600; | |||
There was a problem hiding this comment.
These variables should probably not be static any more given they are mutable within an instance.
| @BindView(R.id.plot) | ||
| XYPlot plot; | ||
| @BindView(R.id.messages) | ||
| TextView msgLabel; | ||
| @BindView(R.id.RSSI_NAME) | ||
| TextView RSSI_NAME; |
There was a problem hiding this comment.
Camel case please for instance variables.
| @BindView(R.id.RSSI_Value) | ||
| TextView RSSI_Value; | ||
| @BindView(R.id.MIN_MHZ) | ||
| EditText MIN_MHZ; |
There was a problem hiding this comment.
Not obvious from the name what the purpose of MIN/MAX_MHZ vs MIN/MAX_FREQ.
| } | ||
|
|
||
| @OnCheckedChanged(R.id.LBandSwitch) | ||
| public void onLBandSwitch() { |
There was a problem hiding this comment.
Would be nice to have presets for every band, maybe something for a future PR.
| @@ -75,6 +75,9 @@ public LapStats readLapStats(long currentTime) throws IOException { | |||
| byte laps = buf[0]; | |||
| int msSinceLastLap = read16(buf, 1); | |||
| stats.rssi = buf[3]; | |||
| if (stats.rssi < 0) { | |||
There was a problem hiding this comment.
Not quite sure what this is about. Note rssi < 0 (unsigned 0xFF) is used to indicate an error. Makes better sense to throw an exception or skip the reading.
add L_band option, fast scanning mode option, change app name to Frequency scanner