Check for valid bag slot before adding tooltip to it #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Is this still relevant? |
|
I am currently not actively playing SoD/Classic and have been using a fork from @romracer with this issue being fixed, so one of his open pull requests might also fix this problem. But in general this problem is probably still relevant. |
|
@DJSchaffner can you rebase this please? |
|
Will take a look at it tomorrow evening :) |
|
My fork has #259 applied which makes this PR not relevant. Since that's been merged here, this can probably be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with custom buttons with custom tooltips from other addons.
Example:
BetterBags creates a dummy button for displaying empty bag slots.
Before:
After:
