Let users handle the cases where required fields are missing

RussellLuo · May 11, 2021 · 5cbf188 · 5cbf188
1 parent 0ac48f0
commit 5cbf188
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/pkg/codec/httpcodec/param.go b/pkg/codec/httpcodec/param.go
@@ -408,14 +408,8 @@ func (p StructParams) Decode(in map[string][]string, out interface{}) error {
 		}
 
 		values := in[kokField.Name]
-		if len(values) == 0 {
-			if !kokField.Required {
-				continue
-			}
-			return ErrMissingRequired
-		}
-
 		fieldValuePtr := reflect.New(fieldValue.Type())
+
 		codec := p.fieldCodec(field.Name)
 		if err := codec.Decode(values, fieldValuePtr.Interface()); err != nil {
 			return err

diff --git a/pkg/codec/httpcodec/param_test.go b/pkg/codec/httpcodec/param_test.go
@@ -946,14 +946,6 @@ func TestStructParams_Decode(t *testing.T) {
 			outPtr:  ptrToValue,
 			wantOut: value{Required: "wow"},
 		},
-		{
-			name: "missing required field",
-			in: map[string][]string{
-				"query.required": nil,
-			},
-			outPtr:  ptrToValue,
-			wantErr: ErrMissingRequired,
-		},
 		{
 			name:    "struct pointer",
 			in:      testIn,