Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs8: eagerly decode PEM labels #1163

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

tarcieri
Copy link
Member

This should give better errors for invalid PEM type labels even if there are subsequent Base64 processing errors, which might occur if e.g. Base64 is wrapped at a nonstandard width.

Notably such errors will include the expected PEM type label.

This should give better errors for invalid PEM type labels even if there
are subsequent Base64 processing errors, which might occur if e.g.
Base64 is wrapped at a nonstandard width.

Notably such errors will include the expected PEM type label.
@tarcieri tarcieri force-pushed the pkcs8/eagerly-decode-pem-label branch from d8cae03 to a96eb35 Compare July 23, 2023 22:46
@tarcieri tarcieri merged commit 47a73cc into master Jul 23, 2023
38 checks passed
@tarcieri tarcieri deleted the pkcs8/eagerly-decode-pem-label branch July 23, 2023 23:01
@tarcieri
Copy link
Member Author

Perhaps SecretDocument could have a better API here that passes in the expected type label when decoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant