cipher+digest: migrate to hybrid array; MSRV 1.65 #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
cipher+digest/hybrid-array
branch
2 times, most recently
from
2c457b6
to
fb64380
Compare
|
@newpavlov well, there's the next step |
Replaces `generic-array` with `hybrid-array`, which is built on a combination of `typenum` and const generics, providing a degree of interoperability between the two systems. `hybrid-array` is designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncrasies.
tarcieri
force-pushed
the
cipher+digest/hybrid-array
branch
from
fb64380
to
f93a1d6
Compare
tarcieri
changed the title
newpavlov
reviewed
Oct 27, 2023
| @@ -195,7 +195,7 @@ impl_counter! { u32 u64 u128 } | |||
| /// In case if `N` is less or equal to 1, buffer of arrays has length | |||
| /// of zero and tail is equal to `self`. | |||
| #[inline] | |||
| fn into_chunks<T, N: ArrayLength<T>>(buf: &mut [T]) -> (&mut [GenericArray<T, N>], &mut [T]) { | |||
| fn into_chunks<T, N: ArraySize>(buf: &mut [T]) -> (&mut [Array<T, N>], &mut [T]) { | |||
There was a problem hiding this comment.
Maybe we should move this method into hybrid-array? I think we had a recent discussion about it.
There was a problem hiding this comment.
Sure, although perhaps that could be a followup?
newpavlov
approved these changes
Oct 27, 2023
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1319.
Replaces
generic-arraywithhybrid-array, which is built on a combination oftypenumand const generics, providing a degree of interoperability between the two systems.hybrid-arrayis designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncrasies.