Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmov: add CmovEq for slices #954

Merged
merged 1 commit into from
Oct 3, 2023
Merged

cmov: add CmovEq for slices #954

merged 1 commit into from
Oct 3, 2023

Conversation

codahale
Copy link
Contributor

@codahale codahale commented Sep 27, 2023 •
edited
Loading

Add a CmovEq impl for slices.

@tarcieri
Copy link
Member

tarcieri commented Oct 3, 2023

I think you should be able to implement this generically as something like:

impl CmovEq for [T]
where
    T: CmovEq
{
   ...
}

@codahale codahale changed the title cmov: add ct_eq for slice comparison cmov: add CmovEq for slices Oct 3, 2023
@codahale
Copy link
Contributor Author

codahale commented Oct 3, 2023

That’s a better idea. Done.

@tarcieri tarcieri merged commit c19c5cc into RustCrypto:master Oct 3, 2023
15 checks passed
@tarcieri tarcieri mentioned this pull request Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codahale @tarcieri