Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2348] shadow effect api #791

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

xiaoyu0722
Copy link
Contributor

New API func shadow(_ style: FioriShadowStyle) -> some View

@xiaoyu0722 xiaoyu0722 requested a review from a team as a code owner September 4, 2024 07:49
@xiaoyu0722 xiaoyu0722 requested review from billzhou0223 and removed request for a team September 4, 2024 07:49
@xiaoyu0722 xiaoyu0722 added the Do not merge yet Do not merge yet label Sep 4, 2024
@xiaoyu0722 xiaoyu0722 added help wanted Extra attention is needed and removed Do not merge yet Do not merge yet labels Sep 5, 2024
@xiaoyu0722
Copy link
Contributor Author

Any suggestions for shadow api are welcome.

struct FioriShadowModifier: ViewModifier {
let style: FioriShadowStyle

let color1 = Color(white: 0, opacity: 0.13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the spec say the color used here should be "white" ? I think opacity on top of a "white" color may not create any visual effect. Also, we need to consider dark mode. So base color should be a dynamic color , I assume. You can follow up with Designer on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all shadows are black(0 white) with opacity and same values for light and dark mode.
Screenshot 2024-09-06 at 07 54 05

@dyongxu dyongxu self-requested a review September 5, 2024 22:20
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadow effect is almost invisible.

@xiaoyu0722 xiaoyu0722 removed the help wanted Extra attention is needed label Sep 10, 2024
@xiaoyu0722
Copy link
Contributor Author

xiaoyu0722 commented Sep 10, 2024

@dyongxu Need review again.

@xiaoyu0722 xiaoyu0722 merged commit d590ad7 into SAP:main Sep 11, 2024
12 checks passed
@xiaoyu0722 xiaoyu0722 deleted the feat-shadow-effect branch September 11, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants