-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2348] shadow effect api #791
Conversation
2c86cf3
to
208c258
Compare
Any suggestions for shadow api are welcome. |
struct FioriShadowModifier: ViewModifier { | ||
let style: FioriShadowStyle | ||
|
||
let color1 = Color(white: 0, opacity: 0.13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the spec say the color used here should be "white" ? I think opacity on top of a "white" color may not create any visual effect. Also, we need to consider dark mode. So base color should be a dynamic color , I assume. You can follow up with Designer on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shadow effect is almost invisible.
208c258
to
193405d
Compare
@dyongxu Need review again. |
New API
func shadow(_ style: FioriShadowStyle) -> some View