feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2348] shadow effect api #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu0722
requested review from
billzhou0223
and removed request for
a team
xiaoyu0722
force-pushed
the
feat-shadow-effect
branch
from
2c86cf3
to
208c258
Compare
xiaoyu0722
added
help wanted
|
Any suggestions for shadow api are welcome. |
dyongxu
reviewed
Sep 5, 2024
| struct FioriShadowModifier: ViewModifier { | ||
| let style: FioriShadowStyle | ||
|
|
||
| let color1 = Color(white: 0, opacity: 0.13) |
There was a problem hiding this comment.
Does the spec say the color used here should be "white" ? I think opacity on top of a "white" color may not create any visual effect. Also, we need to consider dark mode. So base color should be a dynamic color , I assume. You can follow up with Designer on this.
There was a problem hiding this comment.
Yes, all shadows are black(0 white) with opacity and same values for light and dark mode.
dyongxu
approved these changes
Sep 5, 2024
dyongxu
requested changes
Sep 5, 2024
billzhou0223
approved these changes
Sep 6, 2024
JuliaSchnSAP
reviewed
Sep 7, 2024
JuliaSchnSAP
reviewed
Sep 7, 2024
xiaoyu0722
force-pushed
the
feat-shadow-effect
branch
from
208c258
to
193405d
Compare
JuliaSchnSAP
reviewed
Sep 9, 2024
|
@dyongxu Need review again. |
dyongxu
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API
func shadow(_ style: FioriShadowStyle) -> some View