Fixes code review issue

SAP · Nov 19, 2024 · c96dd9c · c96dd9c
1 parent ebb72b0
commit c96dd9c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/code_quality.js b/code_quality.js
@@ -109,16 +109,21 @@ const groupFilesByExtension = (files) => {
  */
 const prettifyFile = async (file, config) => {
   try {
-    const text = fs.readFileSync(file).toString();
-    const check = await prettier.check(text, config);
-    if (check || config?.excludedFiles?.includes(file)) {
+    if (config?.excludedFiles?.includes(file)) {
       return;
     }
 
-    console.log('Running prettier on the file: ' + file);
-    const format = await prettier.format(text, config);
-    fs.writeFileSync(file, format);
-    return true;
+    const fileContent = fs.readFileSync(file).toString();
+    const isFormatted = await prettier.check(fileContent, config);
+
+    if (!isFormatted) {
+      console.log('Running prettier on the file: ' + file);
+      const format = await prettier.format(fileContent, config);
+      fs.writeFileSync(file, format);
+      return true;
+    }
+
+    return false;
   } catch (error) {
     console.log('Error in running prettier the file ' + file + ': \n' + error);
   }

diff --git a/container/src/LuigiCompoundContainer.svelte b/container/src/LuigiCompoundContainer.svelte
@@ -1,6 +1,6 @@
 <svelte:options
   customElement={{
-    tag: '',
+    tag: null,
     shadow: 'none',
     props: {
       activeFeatureToggleList: { type: 'Array', reflect: false, attribute: 'active-feature-toggle-list' },

diff --git a/container/src/LuigiContainer.svelte b/container/src/LuigiContainer.svelte
@@ -1,6 +1,6 @@
 <svelte:options
   customElement={{
-    tag: '',
+    tag: null,
     shadow: 'none',
     props: {
       activeFeatureToggleList: { type: 'Array', reflect: false, attribute: 'active-feature-toggle-list' },