We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description
After version 2.9.0 showAlert has no icon on the left side of Alert (seems removed from styles). It works correctly on 2.8.0.
Expected result
Alert should contain icon
Actual result
Steps to reproduce
Create default alert on vanillia javascript example:
document.addEventListener('DOMContentLoaded', function() { const settings = { text: 'Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}', type: 'info', links: { goToHome: { text: 'homepage', url: '/overview' }, goToOtherProject: { text: 'other project', url: '/projects/pr2' }, relativePath: { text: 'relative hide side nav', url: 'hideSideNav' }, neverShowItAgain: { text: 'Never show it again', dismissKey: 'neverShowItAgain' } }, closeAfter: 10000 }; LuigiClient .uxManager() .showAlert(settings) ; });
The text was updated successfully, but these errors were encountered:
Indeed this issue was introduced after Fundamental styles upgrade in version 2.9.0: https://github.com/SAP/luigi/pull/3486/files#diff-7f67769260741e2563407af949f7e54fbf0431d1c607933f6e8a8094e3219e26L12
Sorry, something went wrong.
walmazacn
Successfully merging a pull request may close this issue.
Description
After version 2.9.0 showAlert has no icon on the left side of Alert (seems removed from styles). It works correctly on 2.8.0.
Expected result
Alert should contain icon
Actual result
Steps to reproduce
Create default alert on vanillia javascript example:
The text was updated successfully, but these errors were encountered: