Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon in alert in >=2.9.0 #3821

Closed
darvsorceix opened this issue Jul 16, 2024 · 1 comment · Fixed by #3822
Closed

No icon in alert in >=2.9.0 #3821

darvsorceix opened this issue Jul 16, 2024 · 1 comment · Fixed by #3822
Assignees
Labels
bug Something isn't working ora ora related issues

Comments

@darvsorceix
Copy link

Description

After version 2.9.0 showAlert has no icon on the left side of Alert (seems removed from styles). It works correctly on 2.8.0.

Expected result

Alert should contain icon

image

Actual result

image

Steps to reproduce

Create default alert on vanillia javascript example:

  document.addEventListener('DOMContentLoaded', function() {
    const settings = {
      text: 'Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}',
      type: 'info',
      links: {
        goToHome: { text: 'homepage', url: '/overview' },
        goToOtherProject: { text: 'other project', url: '/projects/pr2' },
        relativePath: { text: 'relative hide side nav', url: 'hideSideNav' },
        neverShowItAgain: { text: 'Never show it again', dismissKey: 'neverShowItAgain' }
      },
      closeAfter: 10000
    };
    LuigiClient
      .uxManager()
      .showAlert(settings)
    ;
  });
@walmazacn walmazacn self-assigned this Jul 16, 2024
@walmazacn walmazacn linked a pull request Jul 16, 2024 that will close this issue
@walmazacn walmazacn added the bug Something isn't working label Jul 16, 2024
@walmazacn
Copy link
Contributor

Indeed this issue was introduced after Fundamental styles upgrade in version 2.9.0:
https://github.com/SAP/luigi/pull/3486/files#diff-7f67769260741e2563407af949f7e54fbf0431d1c607933f6e8a8094e3219e26L12

@hardl hardl added the ora ora related issues label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ora ora related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants