Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing icon in alert #3822

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Adds missing icon in alert #3822

merged 5 commits into from
Jul 18, 2024

Conversation

walmazacn
Copy link
Contributor

@walmazacn walmazacn commented Jul 16, 2024

Description

Changes proposed in this pull request:

  • adds missing icon in alert
  • adds new e2e tests for alert

Related issue(s)

Fixes #3821

@walmazacn walmazacn linked an issue Jul 16, 2024 that may be closed by this pull request
@ndricimrr
Copy link
Contributor

Maybe it would be good to add a Cypress test to check the icon is there. To make sure we don't miss it again 🤔

@ndricimrr ndricimrr self-assigned this Jul 17, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@walmazacn walmazacn merged commit 919367e into main Jul 18, 2024
12 checks passed
@walmazacn walmazacn deleted the 3821-no-icon-in-alert branch July 18, 2024 08:14
@JohannesDoberer JohannesDoberer added bug Something isn't working ora ora related issues labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ora ora related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No icon in alert in >=2.9.0
3 participants