Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the container examples link to docu website side navigation #3690

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Add the container examples link to docu website side navigation #3690

merged 4 commits into from
Apr 16, 2024

Conversation

smahati
Copy link
Contributor

@smahati smahati commented Apr 5, 2024

Description

Changes proposed in this pull request:

  • Added an external link to the container examples page in the sidebar.
  • Added a note to check the path for working on the documentation as GitHub shows README files from nested folders and it's not clear which folder is being referred to.
  • Changed some examples to show a different link being added to a category.

Related issue(s)

Resolves #3687

@ndricimrr ndricimrr self-assigned this Apr 9, 2024
@ndricimrr ndricimrr changed the title add the container examples link to side navigation Add the container examples link to docu website side navigation Apr 9, 2024
ndricimrr
ndricimrr reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. The rest looks good. Nice work

docs/navigation-configuration.md Show resolved Hide resolved
ndricimrr
ndricimrr approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@smahati smahati merged commit 14c43a2 into main Apr 16, 2024
11 checks passed
@smahati smahati deleted the add-container-examples-docs branch April 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

Assignees

@ndricimrr ndricimrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Container Examples to Docu Website Example Category
2 participants
@smahati @ndricimrr