Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-2987 Reset password api #2461

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Dec 16, 2024

Description

This PR adds the api methods and logic for resetting your password.

Jira ticket

DAH-2987

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2461 December 16, 2024 17:52 Inactive
@chadbrokaw chadbrokaw force-pushed the DAH-2987_reset_password_api branch from 8845bca to 1336128 Compare December 16, 2024 18:28
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2461 December 16, 2024 18:29 Inactive
@chadbrokaw chadbrokaw changed the title feat: reset password api feat: DAH-2987 Reset password api Dec 16, 2024
@chadbrokaw chadbrokaw marked this pull request as ready for review December 16, 2024 19:11
@chadbrokaw chadbrokaw requested review from a team, cade-exygy and alulabeshue-sfgov and removed request for a team December 16, 2024 19:11
@chadbrokaw chadbrokaw added needs review Pull request needs review and removed needs review Pull request needs review labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants