View trending statuses #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breed
requested changes
Aug 2, 2023
| @JsonProperty("created_at") | ||
| public String createdAt; | ||
| public Instant createdAt; // Changed the type to Instant |
There was a problem hiding this comment.
we want to keep this a string. you can add a utility method to convert to an instance in the Util class. there is already one there for now().
| @@ -113,6 +115,25 @@ Mono<ResponseEntity<List<Status>>> getApiV1AccountsStatuses(@PathVariable String | |||
| limit)) | |||
| .map(ResponseEntity::ok); | |||
| } | |||
| @GetMapping("/api/v1/trends/statuses") | |||
There was a problem hiding this comment.
put a link to the spec you are using. there is a limit and skip parameter that you can easily put in here.
server/src/main/java/edu/sjsu/moth/server/controller/StatusController.java
Outdated
Show resolved
Hide resolved
| @@ -113,6 +115,25 @@ Mono<ResponseEntity<List<Status>>> getApiV1AccountsStatuses(@PathVariable String | |||
| limit)) | |||
| .map(ResponseEntity::ok); | |||
| } | |||
| @GetMapping("/api/v1/trends/statuses") | |||
| Mono<ResponseEntity<List<Status>>> getApiV1TrendingStatuses() { | |||
| return statusService.getAllStatuses() | |||
There was a problem hiding this comment.
you can use skip() and take() before the collectList to do the skipping and taking
| return statusService.getAllStatuses() | ||
| .collectList() | ||
| .map(statusList -> { | ||
| // Sort the statuses based on some criteria (e.g., timestamp, likes, etc.) |
There was a problem hiding this comment.
if you do the skip and take you can just return the list
| @@ -58,4 +82,10 @@ public Mono<List<Status>> getStatusesForId(String username, String max_id, Strin | |||
| int count = limit == null || limit > 40 || limit < 1 ? 40 : limit; | |||
| return statusRepository.findAll(predicate, Sort.by(Sort.Direction.DESC, "id")).take(count).collectList(); | |||
| } | |||
| public Flux<Status> getAllStatuses() { | |||
| return statusRepository.findAll(); | |||
There was a problem hiding this comment.
i don't think we want findAll, you should at list pass skip and limit.
server/src/main/java/edu/sjsu/moth/server/service/StatusService.java
Outdated
Show resolved
Hide resolved
breed
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.