Moved follow repositories & methods to AccountService, created AccountService object in InboxController #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shirlsli
commented
Aug 30, 2023
shirlsli
commented
- Moved followerHandle, userFollow, and paginateFollowers from InboxController to AccountService
- Created AccountService object in InboxController for usersFollowers and usersFollowing to access methods in AccountService
breed
requested changes
Aug 31, 2023
| String follower = inboxNode.get("actor").asText(); | ||
| if (requestType.equals("Follow")) { | ||
| // check id | ||
| if (accountRepository.findItemByAcct(id)==null) { |
There was a problem hiding this comment.
this will never be null.
the if else should be removed and line 99 should start with
return accountRepository.findItemByAcct(id).switchOnEmpty(Mono.error(new RuntimeException("Error: Account to follow does not exist")
.then(followersRepository.findItemById(id)
breed
requested changes
Sep 5, 2023
| @@ -21,7 +22,7 @@ | |||
| </list> | |||
| </option> | |||
| </component> | |||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_17" default="true" project-jdk-name="17" project-jdk-type="JavaSDK"> | |||
| @@ -13,6 +13,7 @@ | |||
| import org.springframework.web.bind.annotation.GetMapping; | |||
| import org.springframework.web.bind.annotation.PatchMapping; | |||
| import org.springframework.web.bind.annotation.PathVariable; | |||
| import org.springframework.web.bind.annotation.PostMapping; | |||
There was a problem hiding this comment.
reformat file to get rid of extra import and space
breed
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.