Outbox responds appropriately when another server makes GET request when sending a status to own server #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shirlsli
commented
Oct 17, 2023
shirlsli
commented
- Sends back correct outbox JSON
…rectly to their get request
breed
reviewed
Oct 18, 2023
| */ | ||
| String returnID = MothController.BASE_URL + "/users/" + id + "outbox"; | ||
| int pageSize = limit != null ? limit : DEFAULT_PAGE_SIZE; | ||
| return new OutboxSenderResponse(returnID, "OrderedCollection", 3, returnID + "?page=1", |
There was a problem hiding this comment.
i notice you hard code 3 things in. is this going to create a problem since you aren't including anything? perhaps hardcoding 0 would be better?
breed
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.