Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated Node.js 16 actions #131

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

hamirmahal
Copy link
Collaborator

fixes #130.

@hamirmahal hamirmahal self-assigned this Feb 19, 2024
uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6
# Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
- name: Update dependency graph
uses: advanced-security/maven-dependency-submission-action@v4.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use @v4.0.0 here, specifically, and not @v4, due to some issues with this GitHub Action at the time of this writing.

@hamirmahal
Copy link
Collaborator Author

Without this change

image

With this change

image

Copy link
Contributor

@breed breed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks hamir!

@hamirmahal
Copy link
Collaborator Author

You're welcome, Ben!

@hamirmahal hamirmahal merged commit c5fc7c7 into main Mar 12, 2024
1 check passed
@hamirmahal hamirmahal deleted the fix/deprecated-node-actions-in-ci branch March 12, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated.
2 participants