Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF 5 ADC Implementation Updates for Wall-E #140

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

SuperChamp234
Copy link
Member

This PR contains the changes for using the new ADC implementation as per ESP-IDF 5.1.

With this PR, Wall-E will use the new SRA Board component including the ADC changes for ESP-IDF 5.1. Now, we require to create an adc_handle_t , which is an object of the adc driver, to read from the ADC.

Please review and let me know your suggestions.

@SuperChamp234 SuperChamp234 requested a review from Sidshx February 1, 2024 11:14
Copy link
Collaborator

@Sidshx Sidshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Sidshx Sidshx merged commit 69f4cd5 into SRA-VJTI:master Feb 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants