-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipa: retry restore if it fails to bind to LDAP #123
Conversation
a9affd2
to
0c1f816
Compare
|
0c1f816
to
9ffedb7
Compare
Fixed. By the way, the first commit is actually not needed in the end, but I left it there anyway. |
Looks like this doesn't help. SSSD/sssd#7584 was pinned to use github.com/pbrezina/sssd-test-framework@iparestore still it fails the same way - https://github.com/SSSD/sssd/actions/runs/10938362534/job/30373780704?pr=7584 |
Ok, I will run it and get more logs. Maybe we should run --mh-collect-artifacts=always or at least --mh-collect-logs=always. I used on-failure only to get fast access to logs of failed tests, but it make it difficult to debug this kind of issues. |
c5fa21e
to
331a7e5
Compare
There was a mistake in the first commit and the command was not re-run. Let's see if it works now. |
331a7e5
to
b7ceb75
Compare
@alexey-tikhonov Look like it works now. |
) | ||
|
||
backup_path = str(backup_data) | ||
self.logger.info(f"Restoring IPA server from {backup_path}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what changed in those two lines above so that github shows them as -+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I don't see any change here if I open the forced push diff.
ipa-restore sometimes returns 0 but does not restore IPA correctly. ``` + ipa-restore --unattended --password Secret123 --data --online /tmp/tmp.aBMkEEeqbD/ipa Preparing restore from /tmp/tmp.aBMkEEeqbD/ipa on master.ipa.test Performing DATA restore from DATA backup Temporary setting umask to 022 Each master will individually need to be re-initialized or re-created from this one. The replication agreements on masters running IPA 3.1 or earlier will need to be manually re-enabled. See the man page for details. Disabling all replication. Starting Directory Server Restoring from userRoot in IPA-TEST Unable to bind to LDAP server: Operations error: Restoring from ipaca in IPA-TEST Waiting for LDIF to finish Restoring umask to 18 The ipa-restore command was successful ```
b7ceb75
to
9d51c0a
Compare
Looks so - got 3 green runs in a row. |
I just rebased it, I'll push it once PR CI is finished. |
ipa-restore sometimes returns 0 but does not restore IPA correctly.