Skip to content

Commit

Permalink
CI: Remove dlopen-test from valgrind blacklist
Browse files Browse the repository at this point in the history
Dlopen test was added to blacklist due to following reason:
> Disable running dlopen-tests under Valgrind as their use of dlclose
> makes Valgrind drop symbols and produce meaningless backtraces, which
> cannot be matched with specific suppressions.

It's true that dlclose makes meaningless backtraces but backtraces should
not be generated otherwise there is a bug in some library which need to be
fixed and not suppressed.

Reviewed-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
  • Loading branch information
Lukas Slebodnik committed Oct 19, 2016
1 parent 8a681cc commit bc85b85
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contrib/ci/run
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ function build_debug()
{
# Extended glob pattern matching tests to run under Valgrind.
# NOTE: The particular pattern below is inverted
declare -r valgrind_test_pattern="\
!(*.py|*/dlopen-tests|*/whitespace_test|*/double_semicolon_test)"
declare valgrind_test_pattern="!(*.py|*/whitespace_test|"
declare -r valgrind_test_pattern+="*/double_semicolon_test)"
export CFLAGS="$DEBUG_CFLAGS"
declare test_dir
declare test_dir_distcheck
Expand Down

0 comments on commit bc85b85

Please sign in to comment.