Test: sssclt test case #7457
Open
Test: sssclt test case #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for error if memcache_size_sid is set in nss section. Signed-off-by: Deepak Das <ddas@redhat.com>
DDDas7
force-pushed
the
jira-rhel-28666-sssctl-config-check
branch
from
9ce763a
to
1d02cac
Compare
|
@alexey-tikhonov, I'm still determining. I told @madhuriupadhye, we can approve the test but tag it as deferred. I'm going to perform the housekeeping with a higher priority so we can get new cases in. |
|
@danlavu, any decision? |
|
All of the sssctl tests need to be reworked, but it's not a priority. Let's go ahead and add the test and it'll get reworked with everything else. |
danlavu
reviewed
Aug 21, 2024
| client.sssd.nss["memcache_size_sid"] = "10" | ||
| client.sssd.start(check_config=False) | ||
| result = client.sssctl.config_check() | ||
| assert result.rc == 0, "Config-check failed" |
There was a problem hiding this comment.
For readability, add a line break before the assertions.
|
@DDDas7 rebase, add a blank line, look at covscan errors, this PR is close to being ready to be merged. Let's not forget about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for error if memcache_size_sid is set in nss section.