-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adding gpo customer test scenario to use the ldap attribute name #7621
Conversation
9e31295
to
6e74672
Compare
6e74672
to
f623c33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick on assert message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ignore previous comment about assert message.
f623c33
to
4fe1d9b
Compare
4fe1d9b
to
a7edcf0
Compare
|
53216c0
to
2900936
Compare
Samba topology needs to be dropped from the test case, because the name attribute is not populated. It will take a small-ish patch in the framework to get it working. Let's get this merged and moving, we'll worry about the samba stuff later. Local testing AD passes against sssd-client-2.10.0-1.fc41.x86_64
|
I'd say: let's fix framework. |
fc05e88
to
e599b96
Compare
e599b96
to
05ea421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks.
The failure is not related to the patch. |
No description provided.